Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --include --exclude to s3 ls #4941

Draft
wants to merge 13 commits into
base: develop
Choose a base branch
from

Conversation

wingkwong
Copy link

Issue #, if available:
#4832

Description of changes:
Add --include --exclude to s3 ls

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-io
Copy link

codecov-io commented Feb 11, 2020

Codecov Report

Merging #4941 (9080e12) into develop (97f2a09) will decrease coverage by 0.13%.
The diff coverage is 30.30%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4941      +/-   ##
===========================================
- Coverage    92.63%   92.50%   -0.14%     
===========================================
  Files          196      196              
  Lines        15899    15926      +27     
===========================================
+ Hits         14728    14732       +4     
- Misses        1171     1194      +23     
Impacted Files Coverage Δ
awscli/customizations/s3/subcommands.py 93.01% <30.30%> (-4.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97f2a09...9080e12. Read the comment docs.

@christophertull
Copy link

Would love to see this merged!

@pierrotevrard-dbit
Copy link

How can we get this feature merged, please?

@wingkwong
Copy link
Author

Can someone help review this PR please?

@RealDrewKlayman
Copy link

Would love to see this!

@vladimirsvicevicsrb
Copy link

Would really like to see this feature going live.
Are there any updates on this? 🤔

@justindho justindho linked an issue May 27, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #4941 (b616a94) into develop (cab1b4d) will decrease coverage by 0.13%.
The diff coverage is 30.30%.

❗ Current head b616a94 differs from pull request most recent head 71f5624. Consider uploading reports for the commit 71f5624 to get more accurate results

@@             Coverage Diff             @@
##           develop    #4941      +/-   ##
===========================================
- Coverage    92.63%   92.50%   -0.14%     
===========================================
  Files          203      203              
  Lines        16129    16156      +27     
===========================================
+ Hits         14941    14945       +4     
- Misses        1188     1211      +23     
Impacted Files Coverage Δ
awscli/customizations/s3/subcommands.py 93.01% <30.30%> (-4.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cab1b4d...71f5624. Read the comment docs.

@tuanardouin
Copy link

Almost there, would love to see that to !

@wingkwong wingkwong requested review from TobiasDummschat and removed request for kyleknap October 5, 2022 16:27
@andreineculau
Copy link

@TobiasDummschat last review in July was just about a duplicate title. Does that mean you could give a LGTM now and merge this?

@danielenricocahall
Copy link

This would be nice to get in!

@wingkwong
Copy link
Author

@stealthycoin @TobiasDummschat It's been a while. Can help re-review?

@aBurmeseDev
Copy link
Member

Hi all - I wanted to provide an update here. This was recently brought up to team discussion and we'll need to do further investigation on this. Though we can't share a definite timeline, we now have a backlog item for the team and will post further updates here. In the meantime, I'm going to convert this to draft.

@aBurmeseDev aBurmeseDev marked this pull request as draft September 26, 2023 22:00
@chhh
Copy link

chhh commented Sep 26, 2024

it's a 4 year old PR, with an "update" from a year ago. For what seems to be a simple feature and a very coherent addition to make ls and cp commands work in similar ways. Still nothing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

aws s3 ls --include --exclude