-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --include --exclude to s3 ls #4941
base: develop
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #4941 +/- ##
===========================================
- Coverage 92.63% 92.50% -0.14%
===========================================
Files 196 196
Lines 15899 15926 +27
===========================================
+ Hits 14728 14732 +4
- Misses 1171 1194 +23
Continue to review full report at Codecov.
|
Would love to see this merged! |
How can we get this feature merged, please? |
Can someone help review this PR please? |
Would love to see this! |
Would really like to see this feature going live. |
Codecov Report
@@ Coverage Diff @@
## develop #4941 +/- ##
===========================================
- Coverage 92.63% 92.50% -0.14%
===========================================
Files 203 203
Lines 16129 16156 +27
===========================================
+ Hits 14941 14945 +4
- Misses 1188 1211 +23
Continue to review full report at Codecov.
|
Almost there, would love to see that to ! |
@TobiasDummschat last review in July was just about a duplicate title. Does that mean you could give a LGTM now and merge this? |
This would be nice to get in! |
@stealthycoin @TobiasDummschat It's been a while. Can help re-review? |
Hi all - I wanted to provide an update here. This was recently brought up to team discussion and we'll need to do further investigation on this. Though we can't share a definite timeline, we now have a backlog item for the team and will post further updates here. In the meantime, I'm going to convert this to draft. |
it's a 4 year old PR, with an "update" from a year ago. For what seems to be a simple feature and a very coherent addition to make |
Issue #, if available:
#4832
Description of changes:
Add --include --exclude to s3 ls
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.